ZF-11663: Zend_Oauth_Client ignores GET parameters that are set via setParameterGet
Description
Adding the following line (in file Zend/Oauth/Client.php in function prepareOauth()):
$params = array_merge($params, $this->paramsGet);
just before:
if (!empty($this->paramsPost)) {
fixed the bug for me.
Comments
Posted by Adam Lundrigan (adamlundrigan) on 2011-08-27T20:17:00.000+0000
The issue here is that {{Zend_Oauth_Client}} takes the GET parameters directly from the URI provided:
So, we have two sources of GET parameters. That begs the question: Which takes precedence, the ones set in the URI or the ones set directly in the client?
Posted by Adam Lundrigan (adamlundrigan) on 2011-08-27T21:01:15.000+0000
After talking with [~padraic] on IRC, it was decided that URI parameters should take precedence over those set by the client using {{setParameterGet}}.
Reproducing test case:
Fix:
After applying fix, reproducing test case passes.
Posted by Adam Lundrigan (adamlundrigan) on 2011-08-27T22:09:46.000+0000
Fixed in trunk r24414 Merged to release-1.11 in r24415
Posted by Adam Lundrigan (adamlundrigan) on 2011-08-28T15:18:24.000+0000
GitHub pull request issued against {{padraic/zf2}} branch {{zend-oauth-cleanup}} https://github.com/padraic/zf2/pull/1